New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-53179] Extend env variable to facilitate the access to the BO URLs #24
Conversation
pom.xml
Outdated
@@ -73,7 +73,7 @@ | |||
<dependency> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>display-url-api</artifactId> | |||
<version>2.3.1</version> | |||
<version>2.3.2-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Change the version with the incremental one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as jenkinsci/display-url-api-plugin#26 is merged then jenkinsci/display-url-api-plugin#25 will generated an incremental artifact which could be used in this case
src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java
Outdated
Show resolved
Hide resolved
Anything this patch needs before it can be merged in? Lots of articles pointing to the fact it needs to be solved, has been, but hasn't been pushed fully into the plugin? |
Need to address some of the concerns in jenkinsci/display-url-api-plugin#25 in order to move forward |
Is anything still needed for this patch to be merged in? This feature would be extremely useful to me right now and it seems ready to merge. |
I'm just a contributor, the maintainer is the one to review this PR and merge if happy with |
@jenkinsci/code-reviewers this PR has been stalled for a year or so, any feedback? |
@v1v can you please rebase? I would prefer a released version of https://github.com/jenkinsci/display-url-api-plugin but that's my job to do it I guess ;) |
Certainly this should not be merged while referring to an incremental dependency version. What I have done in the past as a plugin maintainer, or recommended other maintainers do: release the upstream plugin, then use GH suggest changes to guide the downstream PR author to switch to the new release version. At that point downstream is safe to merge & release. (No need for the PR author to rebase; maintainer can always squash-merge if they enjoy destructive history operations.) |
@v1v version 2.3.3 done please update your pull request thanks |
(plus merge conflict resolution) |
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@timja oh yes I will do it early next week |
@olamy When do you have time to release the version 2.4 of the plugin ? |
Thank you ! 💯 |
JENKINS-53179
Enable URLs for a page that displays tests and artifacts for a Run.
Depends on jenkinsci/display-url-api-plugin#25
Highlights
RUN_ARTIFACTS_DISPLAY_URL
points out to the qualified URL for a page that displays artifacts for a RunRUN_TESTS_DISPLAY_URL
points out to the qualified URL for a page that displays tests for a RunUI
@jenkinsci/code-reviewers